Fixes limits on Arrow for plexus test #14781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow must be <1.0.0 for plexus to work
|
I pushed new constraints manually and they caused the test in plexus to fail because of this. I am reverting constraints shortly but this is a permanent fix (until at least plexus provider will be upgraded to use the new arrow release. |
dstandish
approved these changes
Mar 14, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 24, 2021
Plexus provider needlessly limits arrow to <1.0.0. This was added in apache#14781 to fix failing tests, but Plexus uses arrow in a very limited way and it turned out that just checking for None value before running arrow.get(), fixes the problem (and we can upgrade to latest version of arrow as well).
potiuk
added a commit
that referenced
this pull request
May 24, 2021
Plexus provider needlessly limits arrow to <1.0.0. This was added in #14781 to fix failing tests, but Plexus uses arrow in a very limited way and it turned out that just checking for None value before running arrow.get(), fixes the problem (and we can upgrade to latest version of arrow as well).
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 22, 2021
Plexus provider needlessly limits arrow to <1.0.0. This was added in apache#14781 to fix failing tests, but Plexus uses arrow in a very limited way and it turned out that just checking for None value before running arrow.get(), fixes the problem (and we can upgrade to latest version of arrow as well). (cherry picked from commit 5dd0802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow must be <1.0.0 for plexus to work
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.